Combine XPerience

Derplodactyl
Posts: 499
Joined: Sat Dec 23, 2017 7:09 pm

Re: Combine XPerience

Post by Derplodactyl »

yumi wrote: Sat Nov 28, 2020 4:29 pm
Derplodactyl wrote: Sat Nov 28, 2020 2:20 pm Hi!

Excellent addition - my only suggestion would be whether we could make the HUD smaller/larger, and move it around to a different place on the screen?

The other issue I'm finding is that the numbers/letters/symbols are not inside the black box currently (I will fetch a screenshot if necessary) - I believe this could be down to the HUD scaling settings, though I need to check that!

Again, fantastic mod. :)
Hello,

Yes hud could be improved, I wanted something simple at first.
Please share screenshot so I can see why you have text outside the hud.
Thx
Apologies for the slow reply...

The text appears in the blue area marked - I do run 70% HUD scale, and I need to check whether this is teh cause. :)

Image
- James G | Derplodactyl (The Jaggler)
- Giants Ambassador 🇬🇧
- PC & Xbox One

PC Specs:
-AsRock B550M Extreme4 Steel Legend
-AMD Ryzen 9 5900X
-EVGA RTX 3080Ti XC3 Ultra
-Corsair 32GB DDR4 @3600MHz
-1TB Samsung 970 Evo Pro M.2 + 256gb NVMe Storage
User avatar
yumi
Posts: 243
Joined: Sun Jun 19, 2016 5:48 pm
Contact:

Re: Combine XPerience

Post by yumi »

Thanks Derplodactyl. I think the scale is the issue. I'm currently changing some code to fix it.
moreRealistic fan !
FS19 "mr" on Old Farm Coutryside and Champs de France.
Give a try to ContractorMod!
Contractor Mod Beta version for FS22
All released mods source code is on Github
Derplodactyl
Posts: 499
Joined: Sat Dec 23, 2017 7:09 pm

Re: Combine XPerience

Post by Derplodactyl »

My pleasure, thank you for the excellent addition to the game! 🙌🏼
- James G | Derplodactyl (The Jaggler)
- Giants Ambassador 🇬🇧
- PC & Xbox One

PC Specs:
-AsRock B550M Extreme4 Steel Legend
-AMD Ryzen 9 5900X
-EVGA RTX 3080Ti XC3 Ultra
-Corsair 32GB DDR4 @3600MHz
-1TB Samsung 970 Evo Pro M.2 + 256gb NVMe Storage
Zurk
Posts: 1
Joined: Sat Dec 05, 2020 9:00 pm

Re: Combine XPerience

Post by Zurk »

Hi
At first very nice Mod but i noticed something.
When you attach a Frontshield to a harvester the Log gets spammed full with 2 Errors:

Code: Select all

2020-12-05 21:19 Error: Running LUA method 'update'.
2020-12-05 21:19 C:/Users/slims/Documents/My Games/FarmingSimulator2019/mods/FS19_CombineXP/src/xpCombine.lua:214: attempt to index local 'spec_cutter' (a nil value)
2020-12-05 21:19 Error: Running LUA method 'draw'.
2020-12-05 21:19 C:/Users/slims/Documents/My Games/FarmingSimulator2019/mods/FS19_CombineXP/src/xpCombine.lua:600: attempt to call method 'getIsTurnedOn' (a nil value)
2020-12-05 21:19 Error: Running LUA method 'update'.
2020-12-05 21:19 C:/Users/slims/Documents/My Games/FarmingSimulator2019/mods/FS19_CombineXP/src/xpCombine.lua:214: attempt to index local 'spec_cutter' (a nil value)
2020-12-05 21:19 Error: Running LUA method 'draw'.
2020-12-05 21:19 C:/Users/slims/Documents/My Games/FarmingSimulator2019/mods/FS19_CombineXP/src/xpCombine.lua:600: attempt to call method 'getIsTurnedOn' (a nil value)
2020-12-05 21:19 Error: Running LUA method 'update'.
2020-12-05 21:19 C:/Users/slims/Documents/My Games/FarmingSimulator2019/mods/FS19_CombineXP/src/xpCombine.lua:214: attempt to index local 'spec_cutter' (a nil value)
2020-12-05 21:19 Error: Running LUA method 'draw'.
2020-12-05 21:19 C:/Users/slims/Documents/My Games/FarmingSimulator2019/mods/FS19_CombineXP/src/xpCombine.lua:600: attempt to call method 'getIsTurnedOn' (a nil value)
Thank you for the nice Mod and i hope you can fix it
kwadrat530
Posts: 22
Joined: Wed Jun 17, 2020 3:11 pm

Re: Combine XPerience

Post by kwadrat530 »

A little suggestion from me:

Code: Select all

if basePerf <= 0 then
    -- Then motorConfiguration hp
        local coef = 1.5
        local keyCategory = "vehicle.storeData.category"
        if getXMLString(self.xmlFile, keyCategory) == "forageHarvesters" then
            coef = 6.
		elseif getXMLString(self.xmlFile, keyCategory) == "beetVehicles" then
            coef = 0.4
		elseif getXMLString(self.xmlFile, keyCategory) == "potatoVehicles" then
            coef = 0.3
        end
        local key, motorId = ConfigurationUtil.getXMLConfigurationKey(self.xmlFile, self.configurations.motor, "vehicle.motorized.motorConfigurations.motorConfiguration", "vehicle.motorized", "motor")
        local fallbackConfigKey = "vehicle.motorized.motorConfigurations.motorConfiguration(0)"
        local fallbackOldKey = "vehicle"
        local power = ConfigurationUtil.getConfigurationValue(self.xmlFile, key, "", "#hp", getXMLString, nil, fallbackConfigKey, fallbackOldKey)
        if power ~= nil and tonumber(power) > 0 then
            --print("key "..key)
            --print("motorId "..motorId)
            --print("power "..power)
            basePerf = tonumber(power) * coef
            print("Combine basePerf computed from motorConfiguration hp: "..tostring(power).." => "..tostring(basePerf))
        else
    -- Then specs power
            key = "vehicle.storeData.specs.power"
            local specsPower = getXMLString(self.xmlFile, key)
            if specsPower ~= nil and tonumber(specsPower) > 0 then
                basePerf = tonumber(specsPower) * coef
                print("Combine basePerf computed from specs power declared in store: "..tostring(specsPower).." => "..tostring(basePerf))
            end
        end
    end
User avatar
yumi
Posts: 243
Joined: Sun Jun 19, 2016 5:48 pm
Contact:

Re: Combine XPerience

Post by yumi »

kwadrat530 wrote: Sat Dec 05, 2020 10:07 pm A little suggestion from me:

Code: Select all

if basePerf <= 0 then
    -- Then motorConfiguration hp
        local coef = 1.5
        local keyCategory = "vehicle.storeData.category"
        if getXMLString(self.xmlFile, keyCategory) == "forageHarvesters" then
            coef = 6.
		elseif getXMLString(self.xmlFile, keyCategory) == "beetVehicles" then
            coef = 0.4
		elseif getXMLString(self.xmlFile, keyCategory) == "potatoVehicles" then
            coef = 0.3
        end
        local key, motorId = ConfigurationUtil.getXMLConfigurationKey(self.xmlFile, self.configurations.motor, "vehicle.motorized.motorConfigurations.motorConfiguration", "vehicle.motorized", "motor")
        local fallbackConfigKey = "vehicle.motorized.motorConfigurations.motorConfiguration(0)"
        local fallbackOldKey = "vehicle"
        local power = ConfigurationUtil.getConfigurationValue(self.xmlFile, key, "", "#hp", getXMLString, nil, fallbackConfigKey, fallbackOldKey)
        if power ~= nil and tonumber(power) > 0 then
            --print("key "..key)
            --print("motorId "..motorId)
            --print("power "..power)
            basePerf = tonumber(power) * coef
            print("Combine basePerf computed from motorConfiguration hp: "..tostring(power).." => "..tostring(basePerf))
        else
    -- Then specs power
            key = "vehicle.storeData.specs.power"
            local specsPower = getXMLString(self.xmlFile, key)
            if specsPower ~= nil and tonumber(specsPower) > 0 then
                basePerf = tonumber(specsPower) * coef
                print("Combine basePerf computed from specs power declared in store: "..tostring(specsPower).." => "..tostring(basePerf))
            end
        end
    end
Thx, very helpful. I prepared already similar value for beer harvester but have not tested yet potatoes. I'll add this for next update.
FYI, code is on GitHub and open to suggestions (via issues) or PR
moreRealistic fan !
FS19 "mr" on Old Farm Coutryside and Champs de France.
Give a try to ContractorMod!
Contractor Mod Beta version for FS22
All released mods source code is on Github
Derplodactyl
Posts: 499
Joined: Sat Dec 23, 2017 7:09 pm

Re: Combine XPerience

Post by Derplodactyl »

Hey Yumi.

Unsure how you would feel about this, but it came to me as I'm testing a map. As a suggestion, it would be a nice touch to see some MaizePlus compatibility - Triticale, Millet, Spelt, and Fieldgrass for combines. :)
- James G | Derplodactyl (The Jaggler)
- Giants Ambassador 🇬🇧
- PC & Xbox One

PC Specs:
-AsRock B550M Extreme4 Steel Legend
-AMD Ryzen 9 5900X
-EVGA RTX 3080Ti XC3 Ultra
-Corsair 32GB DDR4 @3600MHz
-1TB Samsung 970 Evo Pro M.2 + 256gb NVMe Storage
User avatar
don_apple
Moderator
Posts: 8043
Joined: Thu Oct 28, 2010 9:31 pm
Location: Planet Earth

Re: Combine XPerience

Post by don_apple »

yumi wrote: Sun Dec 06, 2020 12:34 am FYI, code is on GitHub and open to suggestions (via issues) or PR
Maybe you should provide the link to the GitHub repo here, or mention your GitHub account in your signature. Because when searching for the code on Github it is not easy to find.
Gruß/Regards,
don_apple

Apple iMac 27" (2017), Quad-Core i7 4.2 GHz, 48GB, AMD Radeon R580 8GB
Bitte benutzt das öffentliche Forum für Supportfragen und nicht PN/Please use the public forum for support questions and not PM
FS22 Bugtracker
log.txt Image Server Forenregeln Board rules
User avatar
yumi
Posts: 243
Joined: Sun Jun 19, 2016 5:48 pm
Contact:

Re: Combine XPerience

Post by yumi »

don_apple wrote: Sun Dec 06, 2020 3:55 pm
yumi wrote: Sun Dec 06, 2020 12:34 am FYI, code is on GitHub and open to suggestions (via issues) or PR
Maybe you should provide the link to the GitHub repo here, or mention your GitHub account in your signature. Because when searching for the code on Github it is not easy to find.
You're right, I added my github repo link in my signature
moreRealistic fan !
FS19 "mr" on Old Farm Coutryside and Champs de France.
Give a try to ContractorMod!
Contractor Mod Beta version for FS22
All released mods source code is on Github
User avatar
yumi
Posts: 243
Joined: Sun Jun 19, 2016 5:48 pm
Contact:

Re: Combine XPerience

Post by yumi »

Derplodactyl wrote: Sun Dec 06, 2020 3:20 pm Hey Yumi.

Unsure how you would feel about this, but it came to me as I'm testing a map. As a suggestion, it would be a nice touch to see some MaizePlus compatibility - Triticale, Millet, Spelt, and Fieldgrass for combines. :)
Hello,
Yes I can add materialQty coefficient for these crops in the xml config file. Only thing is to estimate how fast the crop can be harvested compared to wheat fully fertilized that is reference crop = 1
moreRealistic fan !
FS19 "mr" on Old Farm Coutryside and Champs de France.
Give a try to ContractorMod!
Contractor Mod Beta version for FS22
All released mods source code is on Github
User avatar
yumi
Posts: 243
Joined: Sun Jun 19, 2016 5:48 pm
Contact:

Re: Combine XPerience

Post by yumi »

Hello,
v1.0.0.2 has been published today to ModHub with fixes for
- HUD text scaling issue
- HUD error when playing on Dedicated Server
- Better management of sugarbeet and potatoes harvesters
I think I will now be able to work on new features for future releases.
moreRealistic fan !
FS19 "mr" on Old Farm Coutryside and Champs de France.
Give a try to ContractorMod!
Contractor Mod Beta version for FS22
All released mods source code is on Github
kwadrat530
Posts: 22
Joined: Wed Jun 17, 2020 3:11 pm

Re: Combine XPerience

Post by kwadrat530 »

I think it would be nice if trailed harvesters used the power of the tractor
User avatar
yumi
Posts: 243
Joined: Sun Jun 19, 2016 5:48 pm
Contact:

Re: Combine XPerience

Post by yumi »

Hello,

I'm planning to add a new constraint for harvesting with Combine Xperience based on 2 possible criteria.
If Seasons mod is loaded, speed could be reduced by crop moisture. From the test I made, it's generally given between ~10% to 20%. Above 20% you cannot harvest anymore with a warning msg from Seasons mod. Moisture is low during the day when sun dries the fields and will increase during the night or after rain.
Idea would be to get this % of speed depending on moisture. For ex in following chart you would reach 50% of max speed (already computed for the given crop with the given harvester & cutter) when moisture is at 19%.
Image
I consider that until 15% you are in good conditions so 100% speed and above it start decreasing.
What do you think ?

Second criteria, if seasons is not loaded, could be based directly on hour of the day.
In the following chart, for cereal, you would get 90% of speed from 12am and 100% until 8pm. It will then really decrease from 2am.
I think for corn it should be different since moisture numbers are different and from what I know you can harvest earlier in the day.
What do you think ?
Image
moreRealistic fan !
FS19 "mr" on Old Farm Coutryside and Champs de France.
Give a try to ContractorMod!
Contractor Mod Beta version for FS22
All released mods source code is on Github
User avatar
Farmercaseih
Posts: 1289
Joined: Thu May 02, 2019 11:14 pm

Re: Combine XPerience

Post by Farmercaseih »

For corn, the moisture doesn't really go up very much, so once it is dry, it stays dry for the most part. I think the crop moisture part would be pretty cool, in 2019 the 30% moisture corn slowed down the combine a little bit lol
User avatar
Farmercaseih
Posts: 1289
Joined: Thu May 02, 2019 11:14 pm

Re: Combine XPerience

Post by Farmercaseih »

Different crops also have different ideal moisture levels, like corn at 15% and beans at 13%, but I don't know if that is really necessary for the game
Post Reply