FollowMe - Follower lights at night are flashing

Eische
Posts: 1799
Joined: Thu Oct 18, 2018 5:17 pm

FollowMe - Follower lights at night are flashing

Post by Eische » Thu Jul 11, 2019 1:07 pm

- PC/Mac/PS4/XB1: PC
- Vehicle/Tool/Model/Object: Any
- Issue: Using FollowMe at night the light of the followers are flashing constantly
- Single- or Multiplayer: SP
- Steps to reproduce: Wait until night and set up a follower
- Does it happen on a standard map without mods yes/no: yes
- Which vehicles & machines are involved: multiple

With game patch 1.4 and the actual version of FollowMe there is a issue with the followers lights at night.
I set up a follower and was driving back to my farm. As it was night, the follower turned on the lights. But the lights do not stay on the whole time. Instead they are flashing (on/off) in quite high frequency.
Before patch 1.4 I did not observe this issue.
PC - Win10

User avatar
Decker_MMIV
Posts: 257
Joined: Wed Aug 22, 2012 1:02 am

Re: FollowMe - Follower lights at night are flashing

Post by Decker_MMIV » Fri Jul 12, 2019 2:38 pm

Thank you for this modhub bug report.

Yes, it does seem that GIANTS' game patch 1.4.1.0 have caused some kind of "bug" to happen with the lights, on following vehicles.
I have not found a sure way to reproduce it on command, but I have now seen it occur in-game.

Unfortunately the GDN's LUADOCs are not up-to-date (they are still at game patch 1.3.0.1) so what have, or have not, happened to the getLightsTypesMask() and setLightsTypesMask() methods are difficult to tell.

The strangeness of this bug, is that in my FollowMe script, this is the only code line which sets the following vehicle's lights to that of the leader. And this code line is called at every update-tick (30 times a second):

Code: Select all

self:setLightsTypesMask( leader:getLightsTypesMask() )
So somehow, perhaps that set-lights-types-mask call ... <Hmm?> "onLightsTypesMaskChanged" ... <I'm getting a hunch feeling about delayed changed events> ... I have to examine more closely whats going on, as I suspect the 1.4.1.0 patch possibly have introduced some base-game script change, that causes a vehicle to "call itself again in the next tick" with regards to the lights states.

Eische
Posts: 1799
Joined: Thu Oct 18, 2018 5:17 pm

Re: FollowMe - Follower lights at night are flashing

Post by Eische » Fri Jul 12, 2019 3:30 pm

Thank you for the quick response!

Yes, that is really strange. But don't need to hurry with a solution. It is only quite annoying when you reach the endpoint of your drive and the follower closes up on your vehicle.
During the drive they usually keep quite a large distance if going full speed, even if both vehicles are the same. So with that large distance you do not see the lights of the follower.
PC - Win10

User avatar
Decker_MMIV
Posts: 257
Joined: Wed Aug 22, 2012 1:02 am

Re: FollowMe - Follower lights at night are flashing

Post by Decker_MMIV » Fri Jul 12, 2019 4:13 pm

I just changed my code to use the "onLightsTypesMaskChanged" events, but that just caused the follower's lights to 'flash one time' (when day time in-game) - so even worse.

After some thinking and experimentation with 'when in day time / night time', I have come to the conclusion that it is most likely the AIVehicle base game script which is "fighting with FollowMe over control of the lights".

Though after some further thinking and script code reading/searching, I found a updateAILights() method - which seems to not be called from anywhere, when using Google to search through the GDN LUADOCs, with the following criteria:

Code: Select all

updateAILights   site:https://gdn.giants-software.com/documentation_scripting_fs19.php
But the content of that method looks like it confirms my experiments.

Adding some 'function overriding' of that method, to prevent it from doing its usual stuff when FollowMe is active, seems to be able to fix the problem. - Though I need to do some further tests, to be sure.

Eische
Posts: 1799
Joined: Thu Oct 18, 2018 5:17 pm

Re: FollowMe - Follower lights at night are flashing

Post by Eische » Tue Oct 15, 2019 7:11 pm

Decker_MMIV wrote:
Fri Jul 12, 2019 4:13 pm
(...)

Adding some 'function overriding' of that method, to prevent it from doing its usual stuff when FollowMe is active, seems to be able to fix the problem. - Though I need to do some further tests, to be sure.
Hi Decker, any update on this?

Today I just did some tests again with the new game update installed.
Not sure if that behaviour was there in the previous game version:

While it is dark outside and have set up a follower, I was cycling through the lights:
1. if all lights of leading vehicle (controlled by yourself) are off, all lights on follower vehicle are flashing
2. if only headlights are on, headlights on follower are on, all other lights are flashing
3. if headlights and rear working lights are on, head/rear are on, front working lights are flashing on follower
4. if all lights are on, no lights on follower are flashing, all are on

While leader and follower still set up, tabbing into the follower vehicle will stop the lights from flashing.

Hope that helps you to find the issue.

I need to mention, that it happend not on all vehicles I tested (Valtra S, Fendt 500, CaseIH Maxxum) constantly. Especially the Valtra S sometimes behaved normal.
PC - Win10

User avatar
Decker_MMIV
Posts: 257
Joined: Wed Aug 22, 2012 1:02 am

Re: FollowMe - Follower lights at night are flashing

Post by Decker_MMIV » Tue Oct 15, 2019 7:32 pm

Hi Eische,

The next update of my mod will have fixed this 'lights flashing'. - Also added is an often requested feature, that this FS19_FollowMe version has lacked for quite some time now.

Regards,
Decker_MMIV

Eische
Posts: 1799
Joined: Thu Oct 18, 2018 5:17 pm

Re: FollowMe - Follower lights at night are flashing

Post by Eische » Tue Oct 15, 2019 7:54 pm

Sweet!
Can't wait to see the update.

Thanks for the quick response!
PC - Win10

Post Reply